[mfaxford]

(Original post by Sparrow_Squire)
this is current JS

function testButton (form){
        	if 
        		(document.testform.getElementByID("pCar").checked
                                {
				document.write("gah");
				}
			else
				(form.getElementByID("dCar").checked
				{
				document.write("blah");
				}
				}

Fixed by adding [ CODE ] and [ /CODE ] tags.

There's the unclosed brackets that's already been mentioned.

Also else doesn't take a parameter so you either want

if (something) {
    action;
} else {
   other_action;
}

or

if (something) {
    action;
} else if (something_else) {
   other_action;
}

the final else statement is taken if none of the preceding actions are taken.

[Sparrow_Squire]

(Original post by mikeyd85)
Now, I'm no dev at all (my experience with ifs come from Excel), but I'd say that bringing in form.rad[1].checked as part of the else statement is superfluous. I would have thought that you'd need a nested if statement to make that work, as well as a third output.

this was 1st attempt it worked but only for the first button iv posted a newer version since x

(Original post by ANARCHY__)
Why document.testform on one line and then form on the other? Surely this would be calling from a different form?

im not sure it just seemed to work better like that. ive just tried it as document.form and altered form name to form thats not working either?

[ANARCHY__]

(Original post by Sparrow_Squire)
this was 1st attempt it worked but only for the first button iv posted a newer version since x





im not sure it just seemed to work better like that. ive just tried it as document.form and altered form name to form thats not working either?

But if you're calling form, that's not correct (as far as I can see) because you're calling an entirely different object where the radio button is not present.

[Sparrow_Squire]

(Original post by ANARCHY__)
But if you're calling form, that's not correct (as far as I can see) because you're calling an entirely different object where the radio button is not present.

oh. ... what do you recommend?

[ANARCHY__]

(Original post by Sparrow_Squire)
oh. ... what do you recommend?

Well, I'd copy and paste your first part of the if statement and then replace the else with this, amending the parts you need to to make it work for the 'else' portion.

[Sparrow_Squire]

confused lol you mean;

<script type="text/javascript" language="javascript">
function testButton (form)
{
for (Count = 0; Count < 3; Count++)
{
if (form.rad[0].checked)
break;
}
alert ("Button " + Count + " is selected");
{
else (form.rad[1].checked)
break;
}
alert ("Button" + Count + "is selected")
}

[Fried Sock]

(Original post by Sparrow_Squire)
confused lol you mean;

<script type="text/javascript" language="javascript">
function testButton (form)
{
for (Count = 0; Count < 3; Count++)
{
if (form.rad[0].checked)
break;
}
alert ("Button " + Count + " is selected");
{
else (form.rad[1].checked)
break;
}
alert ("Button" + Count + "is selected")
}

for (Count = 0; Count < 3; Count++) {
  if (form.rad[Count].checked) {
    alert("Button " + Count + " is selected")
  }  
}

That should do the trick if you copy it exactly

[JamieClark]

(Original post by Fried Sock)

for (Count = 0; Count < 3; Count++) {
  if (form.rad[Count].checked) {
    alert("Button " + Count + " is selected")
  }  
}

That should do the trick if you copy it exactly

It'd probably be best to use the 'var' keyword in the initialization part of the 'for' loop to ensure that the scope of 'Count' is within the loop body only. Without it the variable has global scope and that can lead to all sorts of problems. I suppose it probably won't matter too much here but it's good practice nonetheless.

for (var Count = 0; Count < 3; Count++) {
  if (form.rad[Count].checked) {
    alert("Button " + Count + " is selected")
  }  
}