Boy 2 sounds like a rebound that for some reason you have kept around, even though you don't trust him or need him as much as your ex or even talk to him as much. Boy 1 sounds like the guy you're still not over emotionally even though intellectually you know it's toxic, as you put it.
Honestly, from what I can see? Boy 1, you should cut contact with. You're torturing yourself and not allowing yourself to move on, even after 4 years with someone else. He might be good for you now, he might not, but either way you need the space. Boy 2, you don't feel as strongly about. You are probably leading him on and I think you know that you are - that's why you've kept the fact you talk to your ex a secret. If you were over him and felt secure with your current partner, you'd be open and honest. But you can't be, can you, because you know you do still have feelings for him, to the point you feel lost without him and talk to him every day.
You're not being fair to yourself or the boy you're with. You need to admit you are still clinging to your ex, and I mean truly admit it, before you can start moving on and start a fresh page. Getting caught up in something from so long ago isn't healthy. Listen to your head, not your heart, no matter what the romcoms tell you, sometimes even though it's hard, you have to back off.