As a student at York, the general consensus about colleges is:
Vanbrugh - for students with an interest in music, with a relatively chill vibe. It's not a particularly big college, so there is a sense of community, and it is definitely the best college (not that I'm biased...)
Derwent - Seem to have a rivalry with most of the other colleges and so tend to stick to themselves, but they are renowned for their parties, however, their accommodation is not of the best standard
James - mainly known as being the 'sporty' college
Halifax - is quite segregated from the rest of the campus, and buses are at inconvenient times, meaning that you will always have a 10/15 minute walks to lectures, which may not seem like a lot, but with how cold and wet it gets here, the walk can be a nightmare
Alcuin - quite near to the chemistry building, but don't tend to mix with the rest of the campus as they are not technically on the main site
Constantine, Goodricke and Langwith - as they are on the other campus, they tend to have a community vibe. Their
campus is new and more like an upmarket housing estate than student accommodation, so there is a great atmosphere there. However, there is only one bar on the other campus for the three colleges, and at the moment, there is no onsite shop or doctors, unlike on the main campus, so you may want to take that into consideration.
Ultimately, it doesn't matter which college you choose, as you will grow to love each one, and will definitely enjoy your time at York. Choose the college based on the standard of accommodation and the facilities you want (ensuite, premium rooms, etc), rather than the reputation of the college, because your time here will be what you make it, and you can take an active role in the running of the college to ensure that it becomes the place that you want it to be.
Hope this helps!!