It was too far for me. I decided to go for London instead, but this was based on a number of different reasons too. It all depends on how much you like Edinburgh and whether you will want to visit family/friends often.
I wasn't actually too fond of the city when I visited. I thought I would love it, but something just didn't feel right. A lot of people love the architecture and the atmosphere there, however, I found it to be pretty dark and depressing. :/