Hi, I go to York so I can answer some of your questions!
First of all, well done on researching module choices! Many people don't do this, and end up studying somewhere they're unhappy at because the module choices are a bit rubbish.
I know a few people who do SPS, and they seemed to quite enjoy it. It's an interdisciplinary degree anyway, no? So you have a wide scope of study.
The university itself is excellent, ranking in the top 130-150 in the world, so no question about academic reputation. It's also a stunningly beautiful campus (except for maybe Derwent College), and the city itself is beautiful too. Accommodation wise, I thought it was kind of expensive but there's a lot to choose from. York's also a collegiate university, so there's a lot more involved within the actual accommodation like events, student bars, etc. York is not a very diverse university, it's majority white. In my College for my year, there weren't very many POC, however, there are plenty of societies one can join. Also, to my surprise, there was a quite heavy private school presence at my College as well, which might make some people uncomfortable, but don't worry!
The library is meant to be excellent, although I've not been much.