st andrews has lots of americans & is known well there (could be a con or a pro depending on how u see things). students i know there say that it’s quite hard to walk down the street without seeing someone you know. it’s a lot smaller than edinburgh, but has lots of the shops you would want there as well as lots of small independent shops.
i read somewhere that as there is fewer clubs that lots of students have house parties? not sure how accurate it is. they often go for nights out in dundee apparently as it is quite close.
people have said there’s more of a sense of community in st andrews because the town is the campus really.
both are absolutely beautiful.
not sure how expensive edin accommodation is but st andrews is quite expensive.
edinbrugh’s science buildings are a bit further away from the main area for student accommodation and other subjects. you’d probably have to get the bus or cycle. st andrews is very small so it’s easy to walk or cycle if you want to. i haven’t seen many busses in st andrews when i’ve visited— but there’s lots from st andrews to other cities in scotland. edinburgh has lots of good bus routes across the city.
the points about teaching are good to consider. edinburgh also has a little bit of a reputation for not doing much about student satisfaction (whether this is true or not idk but worth bearing in mind).
visit both if u haven’t already.
whatever one you pick is a fabulous choice!