One I never hear people talk about is Nicolson St/South College St! I stayed there in first year and IMO it was by far the best value accommodation yet, being the cheapest one I applied for.
It's the closest accommodation to the central campus, literally being right around the corner. Buses to Kings are around the corner, and you're a ten minute walk from Pleasance, Drummond St, Lister centre etc.
You're pretty much right in the city centre of Edinburgh. It takes less than 15 minutes to get to Princes St, and Nicolson St is a major bus route so you can easily get basically anywhere in the city.
The bedrooms can be huge. I had a standard and it was massive for a student room. I'd been to my friends flats in Robertsons Close, Kincaid's Court, etc and my room must've been double the size of theirs.
A downside I would bear in mind is the social aspect. The accommodation is pretty small and there's no common room (shared with Robertson's Close), so it can be difficult to meet the other people in your building. It wasn't the stereotypical student accommodation experience, but for the cost I'd say it was 100% worth it!