Are iPhones really that good?

No, it doesn't sound a good move based on a single vague security concern. Do you need extra security for anything specific? Like have you been targeted by a hacker in the past or have a job with sensitive data etc?
(I don't like how Apple stuff works either)

I don't have a security concern regarding a job yet but I'm a medical student and I eventually want to specialise in radiology and so I could have confidently info on my tablet ( not sure if I'm going for iPad or Samsung yet I'll get the tablet that matches my phone) but my friend said there are things you can buy to put on your phone to make it more secure even more secure than iOS.
But that's a few years away yet but I agree it's the only reason I would move to apple and I'm otherwise happy with android and was very impressed with my friends s24 I'm thinking of getting the s25.
Other than my future job after med school then no I've not been hacked it's just I'm always worried incase I did as I know it's easy for people to hack you ect.
I think it's more family telling me you are more safe with apple because no one can hack your cameras and watch you and iOS is closed so more secure which is why I was thinking of making the switch but now I don't really want too because my sister's iPhone is frustrating to use and because of my autism I hate change too.

I'd stick with Android in that case, I'm still on an S10+ but my last few phones have all been Galaxy S's and nothing else has lured me away. I've never had any security issues I'm aware of and there are certainly lots of extra options to enhance security.
I'm honestly not sure how well the idea that android is inherently less secure than iOS still holds up, they've both advanced multiple versions since those issues years ago.