I stayed there a couple of years ago...
•
Great location - well-placed for central campus and Holyrood and not too far from ECA
•
My block had its door blown off in a storm and they did NOT replace it quickly
•
The entrance gate broke and we received a scolding email because some were propping it open (while the uni was not replacing the literal door to our block)
•
Rats and mice. But I didn't really mind those hehe 
The bikes were stolen from the bike shed at one point. The university weren't particularly good about it, and took the view that somehow, it must've been us, the students', fault.
In general, the flats aren't amazing, but they're not going to be amazing anywhere and at least you aren't in the hands of a private landlord! I wouldn't expect a huge increase in quality elsewhere on the university premises. In terms of shopping you have Lidl and Sainsburys Local nearby, and for nightlife there's the Southsider and Brass Monkey pubs close by too. But everything's relatively walkable, and if you do need to go further afield then there's lots of bus routes at Surgeonshall and Nicolson Square.
One thing I found was it was worth investing in blackout blinds. I was in block 11, and it faces onto the Dumbiedikes scheme, so there's usually quite a lot of light from there. But you can get cut-to-fit blackout blinds for a few pounds from IKEA at Straiton.
Important to note that wherever you're staying at, things will happen. It's first year, and you're in with a whole bunch of people. At one flat party, a bunch of people including my flatmate got spiked, and it turned out to be a memepage admin. And I only found out last year that he'd been going around telling people it was me instead (although he got found out in the end). I think it's generally important to remember that even if people seem innocuous, you can't really trust them. You meet some nice people - some stick, others don't. I think that's just the way of things really, and you'll probably meet your more lasting friends later through university, once you've had time to find your feet.
Everywhere's going to have upsides and downsides. So long as you're not miles out (i.e. Beaverbank/Murano/Shrubhill/Haddington, although the tram will have improved things) you're good to go.
Don't forget to grab a YoungScot Card if you've not yet, and you're eligible. Free buses can get you from Stranraer to Scrabster without spending anything. I'm 22 now, and miss mine...